[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-22 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13380 Merging with master, branch-2.0 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60994/ Test PASSed. ---

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #60994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60994/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-21 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13380 LGTM pending tests! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #60994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60994/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-21 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13380 Other than that, this looks ready to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60721/ Test PASSed. ---

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #60721 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60721/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60720/ Test PASSed. ---

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #60720 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60720/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #60721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60721/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #60720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60720/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13380 @jkbradley Let me change it now. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13380 this looks good to me other than deprecating context() and calling the new method session() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-17 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13380 +1 for deprecating ```context()``` now and calling the new method ```session()``` Sorry for the slow response! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-14 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/13380 FWIW, I think since `SQLContext` is deprecated, we should deprecate the `context` methods in `ReadWrite`, and create new methods called `session` (or `withSession`?) for clarity (since `context` is

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60468/ Test PASSed. ---

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #60468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60468/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #60468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60468/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13380 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13380 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59800/ Test PASSed. ---

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #59800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59800/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13380 **[Test build #59800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59800/consoleFull)** for PR 13380 at commit

[GitHub] spark issue #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext with Spar...

2016-06-01 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13380 Those are the only items I'd modify. Basically, I like switching to SparkSession but also maintaining compatibility for public APIs. Changing the private APIs is fine. --- If your project is