[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-07 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13476 Merging this to master and branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/13476 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-06 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13476 Thanks @wangmiao1981 - I think the updated change LGTM. @felixcheung Let me know if you have any more comments --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13476 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60027/ Test PASSed. ---

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13476 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13476 **[Test build #60027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60027/consoleFull)** for PR 13476 at commit [`ce14d78`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13476 **[Test build #60027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60027/consoleFull)** for PR 13476 at commit [`ce14d78`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-04 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/13476 @felixcheung Any more comments? The version check is needed otherwise it can't pass unit tests. All other review comments are done. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13476 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13476 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59952/ Test PASSed. ---

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13476 **[Test build #59952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59952/consoleFull)** for PR 13476 at commit [`d256621`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13476 **[Test build #59952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59952/consoleFull)** for PR 13476 at commit [`d256621`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13476 **[Test build #59948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59948/consoleFull)** for PR 13476 at commit [`b399878`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13476 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59948/ Test FAILed. ---

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13476 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13476 **[Test build #59948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59948/consoleFull)** for PR 13476 at commit [`b399878`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/13476 please remove the workaround in test_context.R --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-02 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13476 @wangmiao1981 the best way to do this is to check the R version using `R.Version()` (similar to what you did in the unit tests) --- If your project is set up for it, you can reply to this email an

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-02 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/13476 @shivaram It seems that integration server uses a lower version of R. Do you know whether has a mechanism to optionally compiling functions by checking version? For example, in C, we can use #i

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13476 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59883/ Test FAILed. ---

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13476 **[Test build #59883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59883/consoleFull)** for PR 13476 at commit [`81e5a31`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13476 **[Test build #59883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59883/consoleFull)** for PR 13476 at commit [`81e5a31`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13476: [SPARK-15684][SparkR]Not mask startsWith and endsWith in...

2016-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13476 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e