Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13619
Reverted commit to branch-1.6 in commit
2f3e327c4cbf163d8536c4451b4829ec7d1886a9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13619
My apologies for the slow response. I'll revert it now. Thank you for
pinging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user zzcclp commented on the issue:
https://github.com/apache/spark/pull/13619
@HyukjinKwon , just see it, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13619
@zzcclp I just did here https://github.com/apache/spark/pull/13630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zzcclp commented on the issue:
https://github.com/apache/spark/pull/13619
@HyukjinKwon , could you revert this pr for branch-1.6 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13619
Yes, it seems it is still failing. I can change the PR to revert this if he
is busy for now. Otherwise, I will close mine.
---
If your project is set up for it, you can reply to this email and
Github user zzcclp commented on the issue:
https://github.com/apache/spark/pull/13619
@HyukjinKwon OK, but this pr should be reverted first.
@jkbradley could you revert this pr for branch-1.6 ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13619
@zzcclp I made a PR against branch-1.6 here,
https://github.com/apache/spark/pull/13630. Thank you for pointing this out
quickly.
---
If your project is set up for it, you can reply to this
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13619
LGTM
Merging with master and branch-2.0
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13619
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13619
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60359/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13619
**[Test build #60359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60359/consoleFull)**
for PR 13619 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13619
**[Test build #60357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60357/consoleFull)**
for PR 13619 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13619
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60357/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13619
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13619
**[Test build #60359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60359/consoleFull)**
for PR 13619 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13619
**[Test build #60357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60357/consoleFull)**
for PR 13619 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13619
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13619
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60353/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13619
**[Test build #60353 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60353/consoleFull)**
for PR 13619 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13619
**[Test build #60353 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60353/consoleFull)**
for PR 13619 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13619
@jkbradley Sure!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13619
@HyukjinKwon Thanks! The fix looks correct. Could you please add a tiny
unit test which fails before your fix & works afterwards?
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13619
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60345/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13619
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13619
**[Test build #60345 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60345/consoleFull)**
for PR 13619 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13619
FYI, it passes in branch-1.6 because it does not check whether the count is
0 or not. This checking is introduced in
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13619
**[Test build #60345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60345/consoleFull)**
for PR 13619 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13619
cc @jkbradley (the cause was quite deeper than I thought).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
29 matches
Mail list logo
