Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
Great! Thanks, @andrewor14 @ajbozarth @yhuai @zsxwing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13620
Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62846/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #62846 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62846/consoleFull)**
for PR 13620 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #62846 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62846/consoleFull)**
for PR 13620 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13620
LGTM. Let's run the test again since this is a pretty old PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13620
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
@yhuai Updated:
> The diff didn't keep track of some lines based on the original ones. The
function `makeRow`of the original `AllJobsPage.scala` is reused. They are
separated at the
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/13620
@nblintao Can you comment on your PR to explain which parts are new code
and which parts are based on existing code?
---
If your project is set up for it, you can reply to this email and have your
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/13620
@nblintao I just finished testing your changes and it looks good. I did
find a odd behavior though, but I think it's intentional in the original
pagination code. If you make the table large
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
I believe this commit has resolved the bugs reported by @ajbozarth. It
looks well on history server pages now, and it could keep the status of other
tables while changing one.
Could you please
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61910/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #61910 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61910/consoleFull)**
for PR 13620 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #61910 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61910/consoleFull)**
for PR 13620 at commit
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
This PR has known bugs about linking. I have fixed the related bugs in
#13708. In order to avoid conflicts, I will not update this PR until #13708 is
merged.
So, please do NOT review or test
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
@ajbozarth Got it, that's a fatal bug. I will fix it in this PR. Thanks
again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/13620
They actually share the core majority of their code so your pagination is
already there, it just can't change pages or change the number of shown jobs. I
think its has to do with how your calling
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
@ajbozarth Thanks for your checking and reporting. I didn't notice that the
UI for history servers are different and just changed the AllJobsPage.
I will try to check the page for history
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/13620
Just opened this in the history server to double check the bug I found on
your stages pr and discovered that this is completely non-functional on the
history server, so I'm striking my earlier
Github user andrewor14 commented on the issue:
https://github.com/apache/spark/pull/13620
also cc @zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/13620
This looks great, I checked out the code and it looks good locally on my
machine as well. I've read through the code and it looks good with the fixes
@andrewor14 suggested so LGTM
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60543/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #60543 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60543/consoleFull)**
for PR 13620 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #60543 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60543/consoleFull)**
for PR 13620 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60469/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #60469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60469/consoleFull)**
for PR 13620 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #60469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60469/consoleFull)**
for PR 13620 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60444/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #60444 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60444/consoleFull)**
for PR 13620 at commit
Github user andrewor14 commented on the issue:
https://github.com/apache/spark/pull/13620
@nblintao this looks pretty good. There were a few methods that don't seem
to be used anywhere. Am I missing something?
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13620
**[Test build #60444 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60444/consoleFull)**
for PR 13620 at commit
Github user andrewor14 commented on the issue:
https://github.com/apache/spark/pull/13620
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13620
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
38 matches
Mail list logo
