[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2017-01-04 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13663 https://github.com/apache/spark/pull/16008 implemented the same solution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-24 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13663 @cloud-fan , @davies , I would appreciate it if you would look at this again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60939/ Test PASSed. ---

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60939/consoleFull)** for PR 13663 at commit [`7ad542d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60939/consoleFull)** for PR 13663 at commit [`7ad542d`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-18 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13663 @cloud-fan , @davies , I would appreciate it if you would look at this again. I think that I had addressed all of your comments. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60639/ Test PASSed. ---

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60639 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60639/consoleFull)** for PR 13663 at commit [`8d7d311`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60639/consoleFull)** for PR 13663 at commit [`8d7d311`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60582/ Test PASSed. ---

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60582/consoleFull)** for PR 13663 at commit [`a193007`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60582/consoleFull)** for PR 13663 at commit [`a193007`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60569/ Test PASSed. ---

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60569/consoleFull)** for PR 13663 at commit [`4458f4f`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60569/consoleFull)** for PR 13663 at commit [`4458f4f`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-14 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13663 @cloud-fan and @davies , thank you for your comments. A global variable is used for 1. I will address 1. by using another approach without using a global variable in another PR. This PR will focus

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-14 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/13663 +1 for @cloud-fan said. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-14 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13663 IIUC, this PR adds a global variable to eliminate some if branches that are very easy to be optimized by javac or JIT. I think this is not a good tradeoff, the readability of the scala cod

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13663 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60495/ Test PASSed. ---

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60495/consoleFull)** for PR 13663 at commit [`9e7b91d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13663: [SPARK-15950][SQL] Eliminate unreachable code at project...

2016-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13663 **[Test build #60495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60495/consoleFull)** for PR 13663 at commit [`9e7b91d`](https://github.com/apache/spark/commit/9