Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13663
https://github.com/apache/spark/pull/16008 implemented the same solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13663
@cloud-fan , @davies , I would appreciate it if you would look at this
again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60939/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60939 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60939/consoleFull)**
for PR 13663 at commit
[`7ad542d`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60939/consoleFull)**
for PR 13663 at commit
[`7ad542d`](https://github.com/apache/spark/commit/7
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13663
@cloud-fan , @davies , I would appreciate it if you would look at this
again. I think that I had addressed all of your comments.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60639/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60639/consoleFull)**
for PR 13663 at commit
[`8d7d311`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60639/consoleFull)**
for PR 13663 at commit
[`8d7d311`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60582/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60582 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60582/consoleFull)**
for PR 13663 at commit
[`a193007`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60582/consoleFull)**
for PR 13663 at commit
[`a193007`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60569/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60569 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60569/consoleFull)**
for PR 13663 at commit
[`4458f4f`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60569 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60569/consoleFull)**
for PR 13663 at commit
[`4458f4f`](https://github.com/apache/spark/commit/4
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13663
@cloud-fan and @davies , thank you for your comments.
A global variable is used for 1. I will address 1. by using another
approach without using a global variable in another PR. This PR will focus
Github user davies commented on the issue:
https://github.com/apache/spark/pull/13663
+1 for @cloud-fan said.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13663
IIUC, this PR adds a global variable to eliminate some if branches that are
very easy to be optimized by javac or JIT.
I think this is not a good tradeoff, the readability of the scala cod
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60495/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60495/consoleFull)**
for PR 13663 at commit
[`9e7b91d`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13663
**[Test build #60495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60495/consoleFull)**
for PR 13663 at commit
[`9e7b91d`](https://github.com/apache/spark/commit/9
26 matches
Mail list logo