[GitHub] spark issue #13811: [SPARK-16100] [SQL] avoid crash in TreeNode.withNewChild...

2016-09-07 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13811 @inouehrs, it looks like this issue has been resolved by #13835, so do you mind closing this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark issue #13811: [SPARK-16100] [SQL] avoid crash in TreeNode.withNewChild...

2016-06-21 Thread inouehrs
Github user inouehrs commented on the issue: https://github.com/apache/spark/pull/13811 Hi @cloud-fan, your fix looks cleaner than mine. As a TODO comment at withNewChildren says, adding validation of the order of children somewhere will help avoiding future bugs caused by classes

[GitHub] spark issue #13811: [SPARK-16100] [SQL] avoid crash in TreeNode.withNewChild...

2016-06-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13811 hi @inouehrs , sorry I haven't noticed that you already have a PR for this JIRA ticket. Yea the root cause of this bug is exactly what you described in your PR descption, thanks for finding th

[GitHub] spark issue #13811: [SPARK-16100] [SQL] avoid crash in TreeNode.withNewChild...

2016-06-21 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/13811 Could you add a test case to reproduce this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark issue #13811: [SPARK-16100] [SQL] avoid crash in TreeNode.withNewChild...

2016-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13811 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat