Github user mallman commented on the issue:
https://github.com/apache/spark/pull/13818
> I have a few questions.
>
> Is it a regression from 1.6? Looks like not?
I don't know about 1.6. I know it's a regression from 1.5.
> Is it a correctness issue or a
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13818
@mallman never mind.
https://github.com/apache/spark/commit/5b7a1770ac9cf36a1e92b31d10fe692fef17
fixed the issue.
---
If your project is set up for it, you can reply to this email and have
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/13818
@zsxwing I was able to do following without error:
git clone g...@github.com:apache/spark.git spark-master
cd spark-master
./dev/change-scala-version.sh 2.10
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13818
FYI this breaks Scala 2.10:
```
[info] Compiling 254 Scala sources and 5 Java sources to
/home/jenkins/workspace/spark-master-compile-sbt-scala-2.10/mllib/target/scala-2.10/classes...
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/13818
I have a few questions.
1. Is it a regression from 1.6? Looks like not?
2. Is it a correctness issue or a performance issue? Seems it is a
performance issue?
3. If it is a
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13818
Shall we also have this in branch-2.0? This seems to be a pretty serious
bug. cc @rxin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13818
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13818
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61730/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13818
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13818
**[Test build #61730 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61730/consoleFull)**
for PR 13818 at commit
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/13818
I believe I've addressed @liancheng's style issues in my new unit test,
along with the same in the two tests from which it was copy-pasta'd (boy scout
rule). Hopefully I didn't cock it up.
---
If
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13818
**[Test build #61730 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61730/consoleFull)**
for PR 13818 at commit
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13818
LGTM except for minor styling issues. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13818
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61594/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13818
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13818
**[Test build #61594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61594/consoleFull)**
for PR 13818 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13818
**[Test build #61594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61594/consoleFull)**
for PR 13818 at commit
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/13818
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/13818
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13818
LGTM, cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/13818
You are very welcome. Thank you for taking time to review it! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13818
seems a reasonable change to me, thanks for working on it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/13818
cc @cloud-fan / @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13818
**[Test build #3124 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3124/consoleFull)**
for PR 13818 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13818
**[Test build #3124 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3124/consoleFull)**
for PR 13818 at commit
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/13818
@hvanhovell I'm mentioning you here because you commented on my previous PR
for this Jira issue. In response to your original question, yes, I have added a
unit test for this patch.
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13818
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
27 matches
Mail list logo
