Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14080
@rxin Thank you for mentioning that. I even didn't notice that. Haha.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14080
@lovexi you should add your commit email to your github profile, so the
commit will show proper attribution.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14080
Merging in master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14080
**[Test build #3185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3185/consoleFull)**
for PR 14080 at commit
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14080
Thank you for reminding me this. Already updated PR description and add
more details.
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14080
**[Test build #3185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3185/consoleFull)**
for PR 14080 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14080
Can you update the pull request description? It is now outdated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14080
Restart test, please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14080
@rxin Thank you for letting me know this. That saves me a lot of time on
testing..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14080
There is a test failure
```
[error] Test
org.apache.spark.network.sasl.SaslIntegrationSuite.testAppIsolation failed:
java.lang.RuntimeException: java.lang.NullPointerException
[error]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14080
**[Test build #3182 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3182/consoleFull)**
for PR 14080 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14080
**[Test build #3182 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3182/consoleFull)**
for PR 14080 at commit
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14080
test this, please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14080
**[Test build #3181 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3181/consoleFull)**
for PR 14080 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14080
**[Test build #3181 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3181/consoleFull)**
for PR 14080 at commit
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14080
test it, please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14080
**[Test build #3180 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3180/consoleFull)**
for PR 14080 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14080
**[Test build #3180 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3180/consoleFull)**
for PR 14080 at commit
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/14080
Thanks, this LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14080
Added some test cases to verify expected metrics values @ericl
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/14080
Thanks for adding these metrics. Could you also add some unit tests to
sanity check these metrics are recorded as expected, e.g. as in
https://github.com/apache/spark/pull/13934/files
---
If your
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14080
@rxin Sure. Get a cleaner title instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
22 matches
Mail list logo
