Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14098
As #14317 has been merged, I close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14098
@liancheng Thanks! I will review the PR #14317
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14098
@wangmiao1981 Thanks for working on this. For the Hive example, I guess you
probably forgot to call `enableHiveSupport()` over the `SparkSession` object.
And I made a mistake about the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62651/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #62651 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62651/consoleFull)**
for PR 14098 at commit
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14098
@liancheng I addressed all your comments. Except: 1). 2-spaces indents; I
tried it, but it failed on python style tests. So I leave it 4-spaces indents;
2) `col('...')` I haven't changed it
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14098
Yea, especially on case insensitive OS'es like Mac and Windows, the doc
actually builds successfully even when cases of the example file names don't
match. I guess that's probably why we missed
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14098
Please be careful with case sensitivity. It broke the release candidate
last time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14098
@wangmiao1981 I guess it's not ready yet. You may put a `[WIP]` tag in the
PR title when it's in WIP status and remove it when it is ready for review.
---
If your project is set up for it, you
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14098
@wangmiao1981 Is this ready for review now? Also, please update the PR
title to:
```
[SPARK-16380][SQL][EXAMPLE] Update SQL examples and programming guide for
Python language binding
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62416/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #62416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62416/consoleFull)**
for PR 14098 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62415/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #62415 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62415/consoleFull)**
for PR 14098 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #62416 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62416/consoleFull)**
for PR 14098 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #62415 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62415/consoleFull)**
for PR 14098 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62413/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #62413 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62413/consoleFull)**
for PR 14098 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #62413 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62413/consoleFull)**
for PR 14098 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62405/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #62405 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62405/consoleFull)**
for PR 14098 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #62405 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62405/consoleFull)**
for PR 14098 at commit
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14098
Not completed. Please hold on for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14098
@liancheng Thanks for your review! I will address your comments asap.
Currently, I am working on a ML wrapper for R.
---
If your project is set up for it, you can reply to this email and
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14098
Thanks for doing this! Overall it's pretty nice. A few high level comments:
1. It might be better to split the whole example file into several methods,
as what #14119 did. In this way,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61940/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #61940 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61940/consoleFull)**
for PR 14098 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #61940 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61940/consoleFull)**
for PR 14098 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #61939 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61939/consoleFull)**
for PR 14098 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61939/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14098
**[Test build #61939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61939/consoleFull)**
for PR 14098 at commit
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14098
@liancheng Can you review it? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
39 matches
Mail list logo
