Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/14158
I'm going to close this PR because it goes stale, please feel free to
reopen it or open another PR if anyone have more thoughts on this issue.
---
-
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@HyukjinKwon Sorry for the delay. I'm busy looking for jobs these days.
I'll try my best to fix it in October. Thank you for reminding me!
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14158
hey @nblintao, do you maybe happened to have some time to continue this one?
---
-
To unsubscribe, e-mail: reviews-unsubscr..
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@HyukjinKwon It's still active. I'll fix it when I'm available. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14158
gentle ping @nblintao, is this PR active? If so, I guess the test failure
should be fixed if related.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78332/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #78332 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78332/testReport)**
for PR 14158 at commit
[`ac96aaa`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #78332 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78332/testReport)**
for PR 14158 at commit
[`ac96aaa`](https://github.com/apache/spark/commit/ac
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/14158
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #78299 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78299/testReport)**
for PR 14158 at commit
[`ac96aaa`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78299/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #78299 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78299/testReport)**
for PR 14158 at commit
[`ac96aaa`](https://github.com/apache/spark/commit/ac
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/14158
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78291/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/14158
i'll retrigger this once jenkins is back up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #78291 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78291/testReport)**
for PR 14158 at commit
[`ac96aaa`](https://github.com/apache/spark/commit/ac
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/14158
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77523/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #77523 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77523/testReport)**
for PR 14158 at commit
[`ac96aaa`](https://github.com/apache/spark/commit/ac
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #77518 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77518/testReport)**
for PR 14158 at commit
[`114401a`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77518/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #77518 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77518/testReport)**
for PR 14158 at commit
[`114401a`](https://github.com/apache/spark/commit/11
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77510/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #77510 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77510/testReport)**
for PR 14158 at commit
[`69180bd`](https://github.com/apache/spark/commit/6
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
I have just rebased. @ajbozarth @HyukjinKwon @gatorsmile @srowen @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #77510 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77510/testReport)**
for PR 14158 at commit
[`69180bd`](https://github.com/apache/spark/commit/69
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@HyukjinKwon Thanks for reminding. I am finals this week. I will fix this
after 15th.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14158
Hi @nblintao, is it still active?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70704/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #70704 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70704/testReport)**
for PR 14158 at commit
[`83cbb58`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #70704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70704/testReport)**
for PR 14158 at commit
[`83cbb58`](https://github.com/apache/spark/commit/83
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70700/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #70700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70700/testReport)**
for PR 14158 at commit
[`83cbb58`](https://github.com/apache/spark/commit/8
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@ajbozarth I finally have a chance to rebase it in the winter break. Could
you please have a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #70700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70700/testReport)**
for PR 14158 at commit
[`83cbb58`](https://github.com/apache/spark/commit/83
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/14158
@nblintao Got it; thanks. There may be distinct queries that will be
entirely the same within the first 1000 characters, but that's just the nature
of working with these very large queries -- t
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@markhamstra Queries longer than 1000 chars are truncated to 1000 chars
after the parsing. "+more" will only expand 140 chars to at most 1000 chars.
---
If your project is set up for it, you can r
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/14158
@nblintao I really haven't reviewed these changes closely enough to have a
specific complaint or concern in mind, but I'm more concerned about what
happens when you ask to see "more" when that "
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@markhamstra Thanks. Here is my related explanation at the top of this PR.
> If the query text is too long (i.e. longer than 1000 chars), it will be
truncated. This is to avoid downing brow
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
Thanks, @ajbozarth. Sure, I'd love to rebase it and get it merged. But I am
really busy with my mid-terms and interviews recently. I'll take a look tonight
and fix it if it's easy to do.
I
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/14158
It's great if it is already addressed, but I just didn't see anything
explicit in the discussion or examples that showed any query of the magnitude
that I am talking about. Machine-generated qu
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/14158
Thanks @markhamstra that was already addressed earlier in review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/14158
Please be certain that this works well even for very large queries. They
are not commonplace, but I know that Spark SQL does sometimes get asked to
handle SQL queries that are hundreds of lines
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/14158
@nblintao Could you rebase? I'd like to try and see if we can get this
reviewed and merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/14158
@srowen @JoshRosen what do you think of @nblintao 's pr? Some of my team
really likes the addition and would love to see it merged
---
If your project is set up for it, you can reply to this emai
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/14158
The tooltip looks odd centered on the column instead of the title text but
I believe that's how the whole Web UI works, other than that nit LGTM
---
If your project is set up for it, you can repl
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/14158
I'll try to take a look at this tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62364/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #62364 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62364/consoleFull)**
for PR 14158 at commit
[`41c2daa`](https://github.com/apache/spark/commit/
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
Updated by truncating long texts and adding a tooltip.
The detail description and the screenshot at
https://github.com/apache/spark/pull/14158#issue-165127460 is also updated.
---
If your proj
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #62364 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62364/consoleFull)**
for PR 14158 at commit
[`41c2daa`](https://github.com/apache/spark/commit/4
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@ajbozarth @felixcheung Thanks for viewing and discussing! I plan to
implement the two updates I mentioned above. The idea of clipboard sounds
awesome, but I think we might need more discussion abo
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/14158
Checked out your changes and I like the updates, plus I think the column
looks better on the end. Addressing the questions you raised: i agree we should
truncate long queries (1000 chars sounds li
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #62207 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62207/consoleFull)**
for PR 14158 at commit
[`beba227`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62207/
Test PASSed.
---
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
**In the commit above, I made three adjustments:**
1. If the query has no related query text, show a blank in that field.
1. If there is no query in the table has a query text, not
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #62207 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62207/consoleFull)**
for PR 14158 at commit
[`beba227`](https://github.com/apache/spark/commit/b
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
Thanks, @ajbozarth. That's a great point. When no execution in a table has
SQL text, this column shouldn't be shown. I'll fix this.
---
If your project is set up for it, you can reply to this emai
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/14158
Checked it out and gave it a test run and it looks good, just one issue.
When the user only uses the dataframes api it will never show any SQL Text
(only "-"), should we check if there is no SQL T
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #62180 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62180/consoleFull)**
for PR 14158 at commit
[`626f3f7`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62180/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14158
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14158
**[Test build #62180 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62180/consoleFull)**
for PR 14158 at commit
[`626f3f7`](https://github.com/apache/spark/commit/6
74 matches
Mail list logo
