[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14257 Thank you, @liancheng and @rxin ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14257 I'm also going to merge this in branch-2.0 to avoid conflicts in fixing bugs in this area. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/14257 LGTM, merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14257 Hi, @liancheng and @rxin . It's not ready for review again. Thank you always! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62896/ Test PASSed. ---

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14257 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14257 **[Test build #62896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62896/consoleFull)** for PR 14257 at commit [`29e953a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14257 **[Test build #62896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62896/consoleFull)** for PR 14257 at commit [`29e953a`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14257 It was Java internal error. ``` # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (sharedRuntime.cpp:834), pid=49858, tid=1404775277708

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14257 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14257 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62893/ Test FAILed. ---

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14257 **[Test build #62893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62893/consoleFull)** for PR 14257 at commit [`29e953a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14257 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14257 **[Test build #62893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62893/consoleFull)** for PR 14257 at commit [`29e953a`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-26 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/14257 LGTM except for one minor comment. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14257 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62862/ Test PASSed. ---

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14257 **[Test build #62862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62862/consoleFull)** for PR 14257 at commit [`16b0f49`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14257 **[Test build #62862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62862/consoleFull)** for PR 14257 at commit [`16b0f49`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14257 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14257 **[Test build #62829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62829/consoleFull)** for PR 14257 at commit [`6b3adbf`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62829/ Test PASSed. ---

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14257 cc @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14257 **[Test build #62829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62829/consoleFull)** for PR 14257 at commit [`6b3adbf`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14257 Now, the PR is updated with new golden SQL files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14257 I removed the new format stuff. I'll update this PR, soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14257 It's just for helping review processes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14257 No problem. We can simply remove `object SQLBuilder` and modify two lines. May I remove those? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #14257: [SPARK-16621][SQL] Generate stable SQLs in SQLBuilder

2016-07-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14257 I'm less sure about the new format -- it leads to tons of whitespaces for very long SQL queries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub