Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14279
@hvanhovell Sure!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14279
@HyukjinKwon could you backport this 2.0? It has merge conflicts so I
cannot cherry pick it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14279
LGTM - merging to master/2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14279
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14279
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64326/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14279
**[Test build #64326 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64326/consoleFull)**
for PR 14279 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14279
**[Test build #64326 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64326/consoleFull)**
for PR 14279 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14279
**[Test build #64065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64065/consoleFull)**
for PR 14279 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14279
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14279
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64065/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14279
**[Test build #64065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64065/consoleFull)**
for PR 14279 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14279
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64061/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14279
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14279
**[Test build #64061 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64061/consoleFull)**
for PR 14279 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14279
**[Test build #64061 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64061/consoleFull)**
for PR 14279 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14279
Oh, wait, I think I can handle this. Please ignore the comments I just
left. Sorry for noise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14279
Sigh.. I will proceed but please let me note that this will also bring a
breaking change for reading as well not only writing..
It seems there is a backwards compatibility problem with
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14279
Yup, thanks for informing me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14279
BTW I think this is pretty important for 2.0.1 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14279
If we are introducing breaking changes to fix the bugs here, let's fix it
for real. (definitely a problem if we can't specify dateFormat and
timestampFormat separately).
---
If your project is set
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14279
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63954/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14279
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14279
**[Test build #63954 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63954/consoleFull)**
for PR 14279 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14279
If `dateFormat` is for `DateType` and `timestampFormat` for
`TimestampType`, I think both can be independently handled although I am
worried of backwards compatibility because `dateFormat` for
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14279
But if dateFormat is set to -MM-dd, then suddenly timestamp output
won't show anything past the date part?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14279
Oh, default for `dateFormat` will be `null` and they will use
`-MM-dd'T'HH:mm:ss.SSSZZ` for timestamps and `-MM-dd` for dates by
default. Test cases for the default for both are added
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14279
Default to dateFormat for timestampFormat seems wrong? Because in that
case all timestamps will be written as -mm-dd only ignoring the rest?
---
If your project is set up for it, you can reply
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14279
Let me please add `timestampFormat`. As CSV already has `dateFormat` option
for both `DateType` and `TimestampType`, Please let me use `dateFormat` for
both if `timestampFormat` is not set if
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14279
@rxin Ah, I see. Yes, it seems we need for each to allow writing dates and
timestamps as the the original format.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14279
**[Test build #63954 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63954/consoleFull)**
for PR 14279 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14279
**[Test build #63918 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63918/consoleFull)**
for PR 14279 at commit
31 matches
Mail list logo
