Github user breakdawn commented on the issue:
https://github.com/apache/spark/pull/14324
@srowen sure, please refer to https://github.com/apache/spark/pull/14404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14324
Darn, this breaks 1.6, because the test doesn't compile. I'll revert it in
1.6. @breakdawn if you're willing, could you open a PR vs 1.6 that updates the
test to work in that branch?
---
If your pr
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14324
Merged to master/2.0/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14324
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62920/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14324
**[Test build #62920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62920/consoleFull)**
for PR 14324 at commit
[`b3f60fa`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14324
**[Test build #62920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62920/consoleFull)**
for PR 14324 at commit
[`b3f60fa`](https://github.com/apache/spark/commit/b
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14324
Jenkins add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14324
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14324
**[Test build #62876 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62876/consoleFull)**
for PR 14324 at commit
[`0d6c29b`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62876/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14324
**[Test build #62876 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62876/consoleFull)**
for PR 14324 at commit
[`0d6c29b`](https://github.com/apache/spark/commit/0
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14324
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user breakdawn commented on the issue:
https://github.com/apache/spark/pull/14324
@rxin @srowen Anything i can follow?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user breakdawn commented on the issue:
https://github.com/apache/spark/pull/14324
@lw-lin Personally, multiple classes way is smoother base on current
implementation. But no matter in what way, it's a big change, maybe it's better
to open another jira issue to involve more disc
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/14324
@breakdawn what else can we do to actually fix the ⥠8118 cols issue?
We're actually running out of the constant pool when we compile the generated
code. So maybe compile it into multiple classes?
Github user breakdawn commented on the issue:
https://github.com/apache/spark/pull/14324
@lw-lin umm, thanks for pointing it out. Since the limit is 8117, 1
will fail, that case needs a update.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14324
There are actually _55_ occurrences of this type of problem in the code
base. I think I will open a PR separately to fix them. It might or might not
cause a problem in practice in other cases, but ma
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/14324
@breakdawn yes that's a different issue and I'm looking into it.
Regarding what this PR tries to fix, could you run this PR's change against
[this test
case](https://github.com/apache/spark/
Github user breakdawn commented on the issue:
https://github.com/apache/spark/pull/14324
8118 cols limit due to janino, the exception like following, might be
another story
at
org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.org$apache$spark$sql$catalyst$expre
Github user breakdawn commented on the issue:
https://github.com/apache/spark/pull/14324
@lw-lin You're right, thanks for your suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/14324
@breakdawn it'd be great to do more tests when you open a request. As I'm
investigate into this too, I found that my same fix works for 201 cols but
fails for 8118 cols. The exact limit is 8117.
--
Github user breakdawn commented on the issue:
https://github.com/apache/spark/pull/14324
Yes, working on that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14324
Can you add a test case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14324
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
26 matches
Mail list logo
