Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/14370
@rxin @cloud-fan sorry for the ambiguity, but we're not enforcing this.
There are 3 levels:
- when `NO_OP` is on (which is the fault), we do nothing at all to a huge
method;
- when
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14370
+1 on @rxin 's idea, I think these checks should belong to VM, the 8k JIT
limit is not the case for all VMs right? and maybe configurable?
---
If your project is set up for it, you can reply to
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14370
Why are we enforcing this? Users can turn on compile huge methods at the VM
level.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/14370
@davies would you also take a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ooq commented on the issue:
https://github.com/apache/spark/pull/14370
Thanks for the PR @lw-lin . I think this check would be useful and ideally
`WARN_IF_EXCEEDS_JIT_LIMIT` should be on by default if the overhead is minimal.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62891/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14370
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14370
**[Test build #62891 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62891/consoleFull)**
for PR 14370 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14370
**[Test build #62891 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62891/consoleFull)**
for PR 14370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14370
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62890/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14370
**[Test build #62890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62890/consoleFull)**
for PR 14370 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14370
**[Test build #62890 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62890/consoleFull)**
for PR 14370 at commit
13 matches
Mail list logo
