Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14397
LGTM (again) - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Thank you, @hvanhovell !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63637 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63637/consoleFull)**
for PR 14397 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63637 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63637/consoleFull)**
for PR 14397 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Hi, @hvanhovell .
Could you review this again? After the last time you've seen, only the
testcase is moved into a new testsuite.
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63637/
Test PASSed.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Thank you, @rxin . It's updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63595/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63595 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63595/consoleFull)**
for PR 14397 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63595/consoleFull)**
for PR 14397 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Hi, @rxin .
Now the testcases are moved into `sql-tests` with `SQLQueryTestSuite`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Oh, now `Exception` is supported at
https://github.com/apache/spark/commit/0db373aaf87991207a7a8a09853b6fa602f0f45b.
Thanks, @rxin . I will try again.
---
If your project is set up for it,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63578/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63577/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63578/consoleFull)**
for PR 14397 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63577/consoleFull)**
for PR 14397 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63578/consoleFull)**
for PR 14397 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63577 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63577/consoleFull)**
for PR 14397 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Rebased just to resolve conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63529/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63529 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63529/consoleFull)**
for PR 14397 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63526/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63526 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63526/consoleFull)**
for PR 14397 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14397
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63529 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63529/consoleFull)**
for PR 14397 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63526 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63526/consoleFull)**
for PR 14397 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Thank you, @hvanhovell !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14397
@dongjoon-hyun this is looking very promising. I left two small comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Thank you so much! Then, see you later. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14397
@dongjoon-hyun I'll take a look in the morning (CET)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Could you review this PR again, @hvanhovell ?
Last time, I did a huge mistake, but now I think I fixed correct according
to your advice.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63371/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63371 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63371/consoleFull)**
for PR 14397 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Hi, @hvanhovell .
Sorry for late update. I updated the PR description and code.
Could you review this PR again?
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #63371 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63371/consoleFull)**
for PR 14397 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
The above approach also can remove the duplicated scope issue between
`CTESubstitution` and `ResolveRelation`.
---
If your project is set up for it, you can reply to this email and have your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Hi, @hvanhovell . It seems not clearly documented, so I did some
comparisons.
First of all, I found that I did overlooked the behavior of the Hive
queries. Hive also uses CTE names
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Oh, sorry for misunderstanding, @hvanhovell . I think we can integrate
`ResolveRelation` and this one. I'll be back after some testing in this
evening. Also for the common approach, I will
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14397
@dongjoon-hyun
New behavior versus existing systems
I was not talking about recursive CTE's (which can be very useful in some
cases). We are changing the behavior of the Analyzer,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Thank you for review, @hvanhovell .
For the recursive CTE queries, traditional DBMS supports optional
`RECURSIVE` keyword which computing **closures**, i.e., it iterates the
subquery
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14397
@dongjoon-hyun I think this has merit. I do have one question, what do
other databases do? Like postgresql, mysql, sqlserver and others?
---
If your project is set up for it, you can reply to
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14397
Hi, @rxin .
Could you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62995/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #62995 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62995/consoleFull)**
for PR 14397 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #62995 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62995/consoleFull)**
for PR 14397 at commit
53 matches
Mail list logo
