Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14400
thanks, merging to master and 2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14400
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14400
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63076/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14400
**[Test build #63076 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63076/consoleFull)**
for PR 14400 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14400
we have an individual style check script: `./dev/scalastyle`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14400
@cloud-fan, just for notice for the next patches: is there a way to run mvn
in a mode that fails on style issues? it could save a lot of round-trips if it
existed.
---
If your project is set up
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14400
**[Test build #63076 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63076/consoleFull)**
for PR 14400 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14400
https://github.com/apache/spark/pull/14400#discussion_r72897142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14400
@cloud-fan, any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14400
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63052/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14400
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14400
**[Test build #63052 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63052/consoleFull)**
for PR 14400 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14400
**[Test build #63052 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63052/consoleFull)**
for PR 14400 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14400
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14400
Good catch!
LGTM except the style comment given by @ueshin . And please also use full
word for variable name, e.g. `originalSchema`, `targetSchema`
---
If your project is set up for it,
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/14400
Good catch!
I have some comments, please check them.
/cc @marmbrus @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14400
@ueshin , you seem to be the original committer of this code. can you
please have a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14400
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
18 matches
Mail list logo
