Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14402
@sakky11 I asked you because I can already see that your change doesn't
even compile, for a third time. This is a trivial change, and not worth
spending more time discussing. Please close this, and
Github user sakky11 commented on the issue:
https://github.com/apache/spark/pull/14402
Any update on this commit ??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user sakky11 commented on the issue:
https://github.com/apache/spark/pull/14402
I know its trivial but it still avoids duplication of code and make it more
readable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/14402
This patch is only a one-line reduction of code and touches a file which
hasn't needed to be modified in ages; is this change really necessary / worth
spending review time on?
---
If your
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14402
Did you compile this locally before pushing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sakky11 commented on the issue:
https://github.com/apache/spark/pull/14402
I think the issue should be fixed now.Sorry for trouble.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sakky11 commented on the issue:
https://github.com/apache/spark/pull/14402
Hey sorry @srowen ,Actually I have fixed the compilation error but missed
it in adding in a pull request.Sorry.
---
If your project is set up for it, you can reply to this email and have your
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14402
@sakky11 you have not even addressed the compilation error. This is wasting
everyone's time. Please _compile_ this locally and fix it before pinging again.
---
If your project is set up for it, you
Github user sakky11 commented on the issue:
https://github.com/apache/spark/pull/14402
Added the required fix.Can you please start the build ??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14402
Yeah, still doesn't compile. Are you compiling this locally?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14402
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14402
**[Test build #63042 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63042/consoleFull)**
for PR 14402 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14402
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63042/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14402
**[Test build #63042 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63042/consoleFull)**
for PR 14402 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14402
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user sakky11 commented on the issue:
https://github.com/apache/spark/pull/14402
Any update on the recent change ??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14402
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
17 matches
Mail list logo
