Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14451
Yeap. Then, let me add a test case and fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14451
That assumes `JDBCRelation` does not extend `SchemaRelationProvider`. Yeah.
That is right so far, but we do not know whether this might be changed.
Normally, the best way is to add a test case
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14451
Sure, I will add. It seems `format("jdbc").load()` thorws an exception
already which is being tested
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14451
Since you are adding more, please introduce a dedicated helper function:
```Scala
private def assertNoSpecifiedSchema(operation: String): Unit = {
if
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14451
For JDBC, you [miss another jdbc
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14451
@gatorsmile, I just updated the PR description and added another
`table(..)` API and the test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14451
**[Test build #70961 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70961/testReport)**
for PR 14451 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14451
Ah, thanks. Let me check out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14451
You just check one `jdbc` API. : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14451
Hi @gatorsmile, could I ask what do you think about this PR for now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14451
**[Test build #70924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70924/testReport)**
for PR 14451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70924/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14451
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14451
**[Test build #70924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70924/testReport)**
for PR 14451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67028/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14451
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14451
**[Test build #67028 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67028/consoleFull)**
for PR 14451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14451
**[Test build #67028 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67028/consoleFull)**
for PR 14451 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14451
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63106/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14451
**[Test build #63106 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63106/consoleFull)**
for PR 14451 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14451
Yeah, keep it open. That PR just tries to get all the possible holes
(corner cases). You know, I do not care which PR is merged, but, in my
opinion, we need to cover all the cases. That is for
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14451
Oh, you took a look already. Yes, it seems your PR includes this change. Do
you mind if I leave this open? This bit seems arguably get merged quickly.
I don't mind if this credits to
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14451
Is this related to: https://github.com/apache/spark/pull/13770?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14451
**[Test build #63106 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63106/consoleFull)**
for PR 14451 at commit
25 matches
Mail list logo
