[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14491 Let's close this in favor of https://github.com/apache/spark/pull/14564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14491 @ganeshchand could you address his last comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14491 @ganeshchand Ah, I see, right. `Dataset` is `DataFrame` so you didn't change? I skimmed through the list I provided and it seems these are all and it seems `structured_network_wordcount.py` is

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-05 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14491 @ganeshchand see for example structure-streaming-programming-guide.md or structured_network_wordcount.py. These have apparently similar comments -- same story right? Also see all the potential

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-05 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14491 No reason to only address this for streaming. Yes, have a look through the rest of these cases to see if they need a similar change. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14491 Oh, this is only about streaming examples. I can look at those in a separate PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14491 Could you look through these as below? at least I found one more. ``` src/main/java/org/apache/spark/examples/ml/JavaDecisionTreeClassificationExample.java: // Load the data

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-04 Thread ganeshchand
Github user ganeshchand commented on the issue: https://github.com/apache/spark/pull/14491 I did verify Python code and Streaming docs. They are OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14491 OK, doesn't need a JIRA. Looks like there are similar occurrences in the Python code, and streaming docs. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #14491: [SPARK-16886] [EXAMPLES][SQL] structured streaming netwo...

2016-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14491 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this