Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14640
OK let's close this one for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user VinceShieh commented on the issue:
https://github.com/apache/spark/pull/14640
@rdelassus Agree. There are a number of folding methods, so some code
refractoring should be done if more folding methods are to be supported in the
future. But for now, I guess we will just
Github user rdelassus commented on the issue:
https://github.com/apache/spark/pull/14640
There is an infinite number of ways to make folds. Until now we had the
mlutils kfold. You want to add the groupedKfold. But I don't think we should
add one by one every folding method that can
Github user VinceShieh commented on the issue:
https://github.com/apache/spark/pull/14640
@finleyb indeed, thank you for pointing it out. I have put it right and
added a test to guard this issue. Many thanks. And feel free to let us know if
you have any problem with this class or any
Github user finleyb commented on the issue:
https://github.com/apache/spark/pull/14640
@VinceShieh I was wondering if require in the groupKFold method of MLUtils
should be a greater than or equal rather than less than or equal? I was testing
this branch because I need this
