[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-09-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14643 OK, we can close this PR then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-09-17 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/14643 @srowen You can take it over. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-09-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14643 Ping @zhengruifeng are you in a position to keep working on this or should I take it over? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-09-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14643 See https://github.com/apache/spark/pull/14949 -- I think we might want to proceed with this with some modifications. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-08-30 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14643 ... for example, ``` /** * Given a vector of class conditional probabilities, select the predicted label. * This returns the class, if any, whose probability is equal to o

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-08-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14643 If it's OK, I'll open a different PR which proposes a simpler behavior: - Return the class with highest probability that is also >= threshold - If no such class exists, return ... NaN? Thi

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-08-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14643 Thresholds are just that -- thresholds. The meaning is certainly as in https://github.com/apache/spark/pull/14643#discussion_r75290480 While I kind of like the idea of also treating them as a 'weigh

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-08-18 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/14643 @srowen I though of `threshoulds` designed in ML just as a kind of `weight`. This design is easy to understand. Is there some other librarys (like sklearn) that support thresholds? We can refe

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14643 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63774/ Test PASSed. ---

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14643 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14643 **[Test build #63774 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63774/consoleFull)** for PR 14643 at commit [`4ec606d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14643: [SPARK-17057][ML] ProbabilisticClassifierModels' predict...

2016-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14643 **[Test build #63774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63774/consoleFull)** for PR 14643 at commit [`4ec606d`](https://github.com/apache/spark/commit/4