Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14663
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14663
I'll go for this tomorrow if there are no other comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64288/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14663
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14663
**[Test build #64288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64288/consoleFull)**
for PR 14663 at commit
[`e263084`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14663
**[Test build #64288 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64288/consoleFull)**
for PR 14663 at commit
[`e263084`](https://github.com/apache/spark/commit/e
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14663
If I understood you correctly @MLnick you favored just adding warnings in
the doc? I added to three more places that needed it.
---
If your project is set up for it, you can reply to this email and
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/14663
Ah right, good point. Actually I realised that the doc in
`ml.feature.StandardScaler` needs updating for `withMean`:
```
/**
* Whether to center the data with mean before scaling
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14663
Warning seems reasonable. I think you'd have to put in a flag to remember
if the user has been warned in order to avoid spewing millions of them. Worth
it, you think?
---
If your project is set up
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/14663
As mentioned on the JIRA discussion, I'm neutral on this, though I tend to
lean towards allowing the user to do what they want even if it might be
"dangerous". I guess +0?
Though perhaps we
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14663
going once, going twice. This would simply let an operation proceed where
it errored before, at the cost of giving a user a little more rope to hang
him/herself. I think it unblocks a legitimate and
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14663
Another one where I'd welcome comments from ... @holdenk @MLnick @davies et
al
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63840/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14663
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14663
**[Test build #63840 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63840/consoleFull)**
for PR 14663 at commit
[`496a8df`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14663
**[Test build #63840 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63840/consoleFull)**
for PR 14663 at commit
[`496a8df`](https://github.com/apache/spark/commit/4
16 matches
Mail list logo
