[GitHub] spark issue #14696: [SPARK-16714][SQL] Refactor type widening for consistenc...

2016-09-24 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/14696 Closing this for now until I revisit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14696: [SPARK-16714][SQL] Refactor type widening for consistenc...

2016-08-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14696 from the previous discussion(https://github.com/apache/spark/pull/14389#issuecomment-236591342): > We also need to add some checks before applying the type widen rules, to avoid conflicting wi

[GitHub] spark issue #14696: [SPARK-16714][SQL] Refactor type widening for consistenc...

2016-08-17 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/14696 @cloud-fan this actually broke decimal precision. I'm starting to think that it would be better to push type coercion into each expression, and then the arithmetic can create special ca

[GitHub] spark issue #14696: [SPARK-16714][SQL] Refactor type widening for consistenc...

2016-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14696 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63973/ Test FAILed. ---

[GitHub] spark issue #14696: [SPARK-16714][SQL] Refactor type widening for consistenc...

2016-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14696 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14696: [SPARK-16714][SQL] Refactor type widening for consistenc...

2016-08-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14696 **[Test build #63973 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63973/consoleFull)** for PR 14696 at commit [`9df4551`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14696: [SPARK-16714][SQL] Refactor type widening for consistenc...

2016-08-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14696 **[Test build #63973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63973/consoleFull)** for PR 14696 at commit [`9df4551`](https://github.com/apache/spark/commit/9