Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14718
thanks, I'll put up a separate pr for branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14718
I thought you were going to merge it yourself, but since you didn't...
merging to master / 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14718
No luck merging to 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64797/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64797 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64797/consoleFull)**
for PR 14718 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64796/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64796/consoleFull)**
for PR 14718 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64797 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64797/consoleFull)**
for PR 14718 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14718
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64796/consoleFull)**
for PR 14718 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14718
I remember now why I hadn't added tests, I was a bit hesitant to expose the
secretManager. I'll add a basic sanity test to make the file is set or not to
make sure it was init'd in time.
---
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14718
we seem to be having random test failures.
I'll see if I can add a test for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64729 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64729/consoleFull)**
for PR 14718 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64729/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64729 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64729/consoleFull)**
for PR 14718 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14718
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64722/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64722 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64722/consoleFull)**
for PR 14718 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14718
Looks good. It'd be nice to update `YarnShuffleServiceSuite` to cover this
scenario (e.g. make sure the app's secret is available before
`initializeApplication` is called).
---
If your project is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64722/consoleFull)**
for PR 14718 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64674/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64674 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64674/consoleFull)**
for PR 14718 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14718
Logic looks ok, I'd just avoid the unneeded work to load the DB when auth
is not enabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64674 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64674/consoleFull)**
for PR 14718 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14718
> how you think the list of executors is acceptable
Ignore me, brain was fried from reading too many patches. Yes you need to
record the secret because this is the shuffle service and it
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14718
thanks for the review, I'll fix up based on the comments. I don't follow
your question or how you think the list of executors is acceptable. This is
doing authentication, you need the secret to
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/14718
LevelDB is JNI so you can't shade it; there's been some careful review so
that YARN NMs and Spark shuffle are in sync here. It's jackson versions which
break things.
---
If your project is
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14718
I was gonna complain about moving the dependency, but it seems like leveldb
already leaks to the user's classpath, so well, damage is already done.
After reading the patch it kinda feels
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14718
ping @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14718
No, it all gets including into one assembly jar used by the nodemanagers
(/spark-${project.version}-yarn-shuffle.jar)
---
If your project is set up for it, you can reply to this email and have
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/14718
Moving the jackson/leveldb dependencies isn't going to create problems on
the yarn shuffle CP are they? Given the versions aren't changing, I'm not too
worried âI just want to make sure
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64094/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64094 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64094/consoleFull)**
for PR 14718 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64094 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64094/consoleFull)**
for PR 14718 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/14718
need to update the test to handle the new levedb
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64074/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64074/consoleFull)**
for PR 14718 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64072/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14718
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64072 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64072/consoleFull)**
for PR 14718 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64074/consoleFull)**
for PR 14718 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14718
**[Test build #64072 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64072/consoleFull)**
for PR 14718 at commit
49 matches
Mail list logo
