[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14778 Hm.. I will close this for now and will ask what we want with this in the JIRA. Thanks again. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14778 I see. Yes, I think that makes sense. Let me convert this PR into fixing typos as below: ``` Returns returns date with the time portion of the day truncated to the unit specified

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14778 This is just my personal impression. You always had better ask advice of committers. Spark community has been reducing the gap between DBMS and SparkSQL. :) --- If your project is set up

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14778 If possible, why don't you make the code more consistently instead of function descriptions? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14778 Ur, @HyukjinKwon . If you compare this with `MySQL` which returns timestamp for timestamp input, e.g., `date_add(current_timestamp(), INTERVAL 1 DAY)`, this might look weird. But,

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14778 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14778 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64325/ Test PASSed. ---

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14778 **[Test build #64325 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64325/consoleFull)** for PR 14778 at commit

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14778 @dongjoon-hyun Thank you for your quick response. I will wait :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14778 Oh, sorry. I'm outside for dinner~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14778 **[Test build #64325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64325/consoleFull)** for PR 14778 at commit

[GitHub] spark issue #14778: [SPARK-17174][SQL] Correct usages and documenations for ...

2016-08-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14778 Hi @dongjoon-hyun, do you mind if I ask a quick look first before cc other committers? (as I saw a related PR was merged). --- If your project is set up for it, you can reply to this email