[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-15 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15014 Ok, that is somewhat convincing. I'll support this since this does have a huge impact. LGTM - merging to master. --- If your project is set up for it, you can reply to this email and ha

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-09 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/spark/pull/15014 In this case , we store a business type by int (to decrease record size). for example, xxx are machine error types, are application types. --- If your project is set up for it, you can reply

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-09 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15014 @cenyuhai why would you want to know the string length of a numeric type? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-09 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/spark/pull/15014 @hvanhovell Why hive is so popular? because hive is compatible and stable. From the user's point of view, hive is easy to use. Users need not care about types all the time. I agree that hive compat

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-09 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15014 I am still not 100% convinced that we should do this. Why is this useable in the first place? It seems to me that someone has made a mistake when this happens. Hive compatibility is not

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15014 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15014 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65144/ Test PASSed. ---

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15014 **[Test build #65144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65144/consoleFull)** for PR 15014 at commit [`3ad4618`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15014 **[Test build #65144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65144/consoleFull)** for PR 15014 at commit [`3ad4618`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-08 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15014 The only one error looks just about the changed behavior in `StringFunctionsSuite`. Could you fix that? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15014 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65109/ Test FAILed. ---

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15014 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15014 **[Test build #65109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65109/consoleFull)** for PR 15014 at commit [`51fe8a1`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15014: [SPARK-17429][SQL] use ImplicitCastInputTypes with funct...

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15014 **[Test build #65109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65109/consoleFull)** for PR 15014 at commit [`51fe8a1`](https://github.com/apache/spark/commit/5