Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/15047
@gatorsmile + @rxin : I had made a note of your comments but was not able
to get to it that time because I had other time critical projects to be worked
on. I have put out a PR which improves th
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15047
Yeah, my previous team also uses a similar FVT tool for populating database
tables. It is pretty useful.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15047
One testing technique we have used internally at Databricks (not for Spark)
is to use random data generator to generate a bunch of data, and run through
the reference implementation to get the results,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15047
@tejasapatil It sounds like the test case coverage is limited. It does not
cover all the data types, right?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/15047
@gatorsmile : I have tests in `HiveHasherSuite` to compare the values
against expected one. Initially I had thought about generating random input and
calling the original Hive's hash function to
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15047
Do we need a test suite for comparing the generated hash value is identical
to the value by Hive?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15047
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66279/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66279 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66279/consoleFull)**
for PR 15047 at commit
[`238dbb8`](https://github.com/apache/spark/commit/
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15047
@tejasapatil I have triggered a new build. I'll merge this as soon as it
completes successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66279 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66279/consoleFull)**
for PR 15047 at commit
[`238dbb8`](https://github.com/apache/spark/commit/2
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15047
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15047
LGTM. I'll let @cloud-fan sign off on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66108/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66108 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66108/consoleFull)**
for PR 15047 at commit
[`238dbb8`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66108 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66108/consoleFull)**
for PR 15047 at commit
[`238dbb8`](https://github.com/apache/spark/commit/2
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/15047
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66069/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66069 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66069/consoleFull)**
for PR 15047 at commit
[`238dbb8`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66069 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66069/consoleFull)**
for PR 15047 at commit
[`238dbb8`](https://github.com/apache/spark/commit/2
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/15047
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66058/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66058 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66058/consoleFull)**
for PR 15047 at commit
[`238dbb8`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66058 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66058/consoleFull)**
for PR 15047 at commit
[`238dbb8`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66027/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66027 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66027/consoleFull)**
for PR 15047 at commit
[`cf62891`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66026/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66026 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66026/consoleFull)**
for PR 15047 at commit
[`afc1d1b`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66027 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66027/consoleFull)**
for PR 15047 at commit
[`cf62891`](https://github.com/apache/spark/commit/c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #66026 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66026/consoleFull)**
for PR 15047 at commit
[`afc1d1b`](https://github.com/apache/spark/commit/a
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15047
@tejasapatil could add this hash to `HashByteArrayBenchmark` and to
`HashBenchmark` and update the results of these tests.
---
If your project is set up for it, you can reply to this email and h
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65615/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #65615 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65615/consoleFull)**
for PR 15047 at commit
[`4ae4856`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65614/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #65614 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65614/consoleFull)**
for PR 15047 at commit
[`8e42799`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #65615 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65615/consoleFull)**
for PR 15047 at commit
[`4ae4856`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #65614 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65614/consoleFull)**
for PR 15047 at commit
[`8e42799`](https://github.com/apache/spark/commit/8
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/15047
@hvanhovell Done with all changes. Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15047
hard coding output seems like a good idea.
additionally, if you want to be super safe, you could also create a
randomized test in sql/hive.
---
If your project is set up for it, you can repl
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/15047
@rxin : I could but the test case depends on few Hive classes for
validation. I could either (keep the test case in sql/hive and move HiveHash to
sql/catalyst) OR (move both to sql/catalyst and
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15047
Can we move this into catalyst.expressions in sql/catalyst?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15047
@tejasapatil this looks pretty good overal. I left a few comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/15047
@rxin : can you recommend me someone for reviewing this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15047
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65214/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #65214 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65214/consoleFull)**
for PR 15047 at commit
[`c898f5a`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15047
**[Test build #65214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65214/consoleFull)**
for PR 15047 at commit
[`c898f5a`](https://github.com/apache/spark/commit/c
55 matches
Mail list logo
