Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15062
the change looks reasonable, merging to master/2.2/2.1/2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76863/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15062
**[Test build #76863 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76863/testReport)**
for PR 15062 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15062
**[Test build #76863 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76863/testReport)**
for PR 15062 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15062
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/15062
This does look the same as SPARK-17109. Does this fix that issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/15062
We were seeing the problem when using the datasets API in our 1.6.1 build,
which is based on Scala 2.10. I recently tried to reproduce this on master with
2.11 and #10970 reverted, but I didn't get
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/15062
any chance that is the same issue as
https://issues.apache.org/jira/browse/SPARK-17109?
@rdblue When you were debugging this issue, which version of scala did you
use? Scala 2.10 or Scala 2.11?
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68939/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15062
**[Test build #68939 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68939/consoleFull)**
for PR 15062 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15062
I'm fine with this change, cc @yhuai @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15062
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15062
**[Test build #68939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68939/consoleFull)**
for PR 15062 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/15062
I tried to reproduce with #10970 reverted, but I didn't hit the issue in
testing. I still think it's fine to move forward on this, even if it is hard to
reproduce because we know the code is wrong
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15062
Hi @rdblue can you revert #10970 in this PR? Then other reviewers can test
this PR locally and verify if it works.
---
If your project is set up for it, you can reply to this email and have your
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/15062
I think the best way to reproduce this is to revert #10970. I don't have a
case that reproduces it that I can share since this was in a fairly large job.
---
If your project is set up for it, you
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15062
I'm just unclear of why this is needed . According to the linked issue,
some tests were failing and this fixed them. Everything just seems very vague
to me. It would be very helpful if you could
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15062
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15062
Oh, I was too quick to comment, I see a complete description is in the JIRA.
It would still be good if you could add a test though.
---
If your project is set up for it, you can reply to this
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15062
I don't quite understand what use-case this patch fixes. Can you provide an
example (in the form of a test) that reproduces the issue?
---
If your project is set up for it, you can reply to this
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/15062
@hvanhovell, I'm not sure what's causing this to build the test. I can step
through with a debugger to see that the problem is caused by an empty
actualTypeArgs list, but I don't know why it is that
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15062
Could you add a regression test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65269/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15062
**[Test build #65269 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65269/consoleFull)**
for PR 15062 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15062
**[Test build #65269 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65269/consoleFull)**
for PR 15062 at commit
28 matches
Mail list logo
