[GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix

2017-05-12 Thread gglanzani
Github user gglanzani commented on the issue: https://github.com/apache/spark/pull/15074 @HyukjinKwon So I think I will close this one. The issue is that there is never a shorter path. Take for example this code ```python C = SparseMatrix(2, 2, [0, 0, 2], [1], [2

[GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix

2017-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15074 @gglanzani Is it still active? If so, could you address the comments above? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix

2016-11-09 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15074 Something like `foreachActive` for matrices would enable a better solution, but if we don't go that route then I agree with @thunterdb about comparing sparse matrices with the same transpose efficien

[GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix

2016-11-08 Thread thunterdb
Github user thunterdb commented on the issue: https://github.com/apache/spark/pull/15074 @dbtsai and @holdenk have a good point about the equality being a actually an equivalence check (we want to check that two matrices have the same content, not that two python objects have the same

[GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix

2016-10-07 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/15074 Maybe it would be good to add some more tests for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix

2016-09-24 Thread gglanzani
Github user gglanzani commented on the issue: https://github.com/apache/spark/pull/15074 @thunterdb any updates here? Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix

2016-09-14 Thread gglanzani
Github user gglanzani commented on the issue: https://github.com/apache/spark/pull/15074 @thunderdb thanks! In that case I'll update the DenseMatrix equality as well, as I've used it as an inspiration! --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix

2016-09-14 Thread gglanzani
Github user gglanzani commented on the issue: https://github.com/apache/spark/pull/15074 @MLnick Thanks, took care of that and grouped inexpensive checks together --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix

2016-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15074 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat