Github user squito commented on the issue:
https://github.com/apache/spark/pull/15213
made a minor comment b/c I saw it, but don't think this should hold up
getting it merged. lgtm for merging as-is and following up later.
---
If your project is set up for it, you can reply to this
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/15213
LGTM. I'm going to merge this in favor of of another RC since the fix here
is correct. If there are any further style suggestions, we can do it in a
follow up PR.
---
If your project is set up
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15213
LGTM. My understanding of @markhamstra's comment above is that he's ok
with this as-is; @squito any last comments here?
Thanks for fixing this @scwf!
---
If your project is set up
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15213
What else is needed to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15213
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66036/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15213
**[Test build #66036 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66036/consoleFull)**
for PR 15213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15213
**[Test build #66036 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66036/consoleFull)**
for PR 15213 at commit
Github user scwf commented on the issue:
https://github.com/apache/spark/pull/15213
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15213
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66031/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15213
**[Test build #66031 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66031/consoleFull)**
for PR 15213 at commit
Github user scwf commented on the issue:
https://github.com/apache/spark/pull/15213
@kayousterhout Thanks for your comment, i have updated based on all your
comment.
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15213
**[Test build #66031 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66031/consoleFull)**
for PR 15213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15213
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66006/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15213
**[Test build #66006 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66006/consoleFull)**
for PR 15213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15213
**[Test build #66006 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66006/consoleFull)**
for PR 15213 at commit
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/15213
> Honestly, I think just getting the fix in is important enough that I'm
fine w/ putting in the minimally invasive thing now.
That's fine, @squito -- go ahead and merge when you're
Github user squito commented on the issue:
https://github.com/apache/spark/pull/15213
gosh this is a serious bug, can't believe we haven't found it already.
Thanks for reporting and working on a fix.
Honestly, I think just getting the fix in is important enough that I'm fine
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/15213
@scwf I understand that you were trying to make the least invasive fix
possible to deal with the problem. That's usually a good thing to do, but even
when that kind of fix is getting to the
Github user scwf commented on the issue:
https://github.com/apache/spark/pull/15213
@markhamstra in my fix i just want to make the minor changes for the
dagscheduer, and your fix is also ok to me, i can update this according your
comment. Thanks:)
/cc @zsxwing may also have
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/15213
The fix is logically correct; however, the prior code is needlessly complex
and not as easy to understand as it should be, and the proposed fix doesn't
improve on that. I'd like to take the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15213
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65853/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15213
**[Test build #65853 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65853/consoleFull)**
for PR 15213 at commit
26 matches
Mail list logo
