[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15246 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-07 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 Thank you for approving, @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-06 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 Hi, @srowen all tests passed this time. Could you please review this PR again? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66482/ Test PASSed. ---

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66482/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66482/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-05 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 `org.apache.spark.streaming.kafka010.DirectKafkaStreamSuite.pattern based subscription` failed again, but it passed in my local laptop. I still think the failure is not related to this PR. @srowen

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66390/ Test FAILed. ---

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66390/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66390/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-05 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15246 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-05 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15246 Jenkins add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-05 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 Hi, @srowen Could you please re-trigger jenkins to retest this? I think the the failure of `org.apache.spark.streaming.kafka010.DirectKafkaStreamSuite.pattern based subscription` is not caused by

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 The changes should be safe to `org.apache.spark.streaming.kafka010.DirectKafkaStreamSuite.pattern based subscription`, I'll re-trigger again. --- If your project is set up for it, you can reply

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 Not sure why `org.apache.spark.streaming.kafka010.DirectKafkaStreamSuite.pattern based subscription` --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66344/ Test FAILed. ---

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66344/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 At commit [2ea3eea](https://github.com/apache/spark/commit/2ea3eeae4f8ec910e2558a482b6fab8275da77f9), it reverted the changes in `CliSuite` and `HiveThriftServer2Suites` since their target files

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66344/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66337/ Test FAILed. ---

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66337/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 Hi, @srowen Thanks for the suggestion. Yes, I have updated the PR to add utility methods for this in SparkFunSuite and include `CliSuite` and `HiveThriftserver2Suites`. The reason `CliSuite` and

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66337/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15246 I wonder if you could make a utility method for this in `SparkFunSuite` ? and then I think there are two more files that load a file from `src/test/resources`, in the `hive-thriftserver` module, as

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 Hi, @srowen Could you please review this again? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66300/ Test PASSed. ---

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66300/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-03 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15246 I have searched `src/test/resource `in the code base to get test cases which hard code `src/test/resources`. Except for two `ignore` tests in `SQLQuerySuite`, for those can not pass in IDE, they

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #66300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66300/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-28 Thread Sherry302
Github user Sherry302 commented on the issue: https://github.com/apache/spark/pull/15246 Hi, @srowen Yes, you are right. I am searching the code base to see if we can fix more. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15246 It's a fair point, though I'm also wondering -- aren't there many other instances of this throughout the tests? in some cases the file would happen to get put on a classpath by the IDE but not

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-27 Thread Sherry302
Github user Sherry302 commented on the issue: https://github.com/apache/spark/pull/15246 Hi, @srowen Thanks a lot for the comments. Yes, setting the working dir can work. However, working dir varies from machine to machine. It would be a little tricky to maintain and troubleshoot in

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15246 Hm, I see why this happens to work, because the file is not packaged inside a jar file. Normally that's what getResource is for, and if it were in a jar this wouldn't work. It's not a bad idea

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65933/ Test PASSed. ---

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #65933 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65933/consoleFull)** for PR 15246 at commit

[GitHub] spark issue #15246: [MINOR][SQL] Use resource path for test_script.sh

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15246 **[Test build #65933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65933/consoleFull)** for PR 15246 at commit