Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15277
OK thank you. I'd like to keep the ability to accept unsorted indices,
because it really isn't something the model needs to demand of its input. It's
an implementation detail. You can just sort and
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15277
@srowen I'm sorry for misunderstand. I'll revert it firstly and let's
continue the discussion. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15277
@yanboliang whoa, no I don't agree with this change. I said so above. There
is an easy way to make this work as it did before. I'd appreciate it if you
reverted this and addressed my comment.
---
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15277
Merged into master. Thanks for all your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15277
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15277
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66093/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15277
**[Test build #66093 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66093/consoleFull)**
for PR 15277 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15277
**[Test build #66093 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66093/consoleFull)**
for PR 15277 at commit
Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/15277
sort in the transform will cause sort too many times.
so this looks good to me. thangks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15277
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66029/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15277
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15277
**[Test build #66029 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66029/consoleFull)**
for PR 15277 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15277
cc @mpjlu @srowen @avulanov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15277
**[Test build #66029 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66029/consoleFull)**
for PR 15277 at commit
14 matches
Mail list logo
