Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15292
@gatorsmile @cloud-fan Thank you for reviewing this both!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15292
Thanks! Merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15292
Ah, right. I just updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15292
Sorry, I did not explain it in details. In this PR, we had a bug fix. We
need a separate bullet in the PR description.
Previously, when attempting to make a database connection, we pass
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15292
Done @gatorsmile Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15292
I will try to verbose the description for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15292
@gatorsmile I guess the PR description already includes the changes here.
Could you please tell me what you think I should include maybe?
---
If your project is set up for it, you can reply to
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15292
Thank you for working on it! Please update the PR description. Ping me when
it is done. Then, I can merge it. : )
---
If your project is set up for it, you can reply to this email and have your
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15292
LGTM, cc @gatorsmile for final sign-off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66653/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66653 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66653/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66653 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66653/consoleFull)**
for PR 15292 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15292
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #3311 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3311/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #3311 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3311/consoleFull)**
for PR 15292 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66636/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66636 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66636/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66636/consoleFull)**
for PR 15292 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66628/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66628 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66628/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66628 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66628/consoleFull)**
for PR 15292 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15292
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66622/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66622 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66622/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66622 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66622/consoleFull)**
for PR 15292 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66606/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66606 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66606/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66606 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66606/consoleFull)**
for PR 15292 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15292
LGTM except 2 minor comments, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66573/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66573 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66573/consoleFull)**
for PR 15292 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66574/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66574 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66574/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66574 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66574/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66573 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66573/consoleFull)**
for PR 15292 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66491/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66491 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66491/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66491 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66491/consoleFull)**
for PR 15292 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15292
BTW, I finished the review. LGTM except the above comments. Let @cloud-fan
double check it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15292
@gatorsmile Sure, let me just wait and sweep it once!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15292
Will continue the review tonight. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66365/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66365 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66365/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66365 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66365/consoleFull)**
for PR 15292 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66318 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66318/consoleFull)**
for PR 15292 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15292
**[Test build #66318 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66318/consoleFull)**
for PR 15292 at commit
56 matches
Mail list logo