[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2017-06-12 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15306 Hm, we could it move the actual throw to the afterAll(), that would cause a suite abort instead but presumably leave the test errors intact. --- If your project is set up for it, you can reply to

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2017-06-12 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/15306 This is good thing for us to test. However, If you throw an exception in your test that opens a file, it seems that it swallows the exception just telling you that you are leaking files. Is

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-10-01 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15306 Merging in master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15306 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66155/ Test PASSed. ---

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15306 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15306 **[Test build #66155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66155/consoleFull)** for PR 15306 at commit

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15306 **[Test build #66155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66155/consoleFull)** for PR 15306 at commit

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15306 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15306 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66143/ Test PASSed. ---

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15306 **[Test build #66143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66143/consoleFull)** for PR 15306 at commit

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-29 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15306 Thanks - this is super useful! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-29 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15306 cc @srowen want to review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15306: [SPARK-17740] Spark tests should mock / interpose HDFS t...

2016-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15306 **[Test build #66143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66143/consoleFull)** for PR 15306 at commit