Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/15335
I read through the code and the discussion and things lgtm. Merging to
master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15335
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70258/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15335
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15335
**[Test build #70258 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70258/testReport)**
for PR 15335 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15335
**[Test build #70258 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70258/testReport)**
for PR 15335 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/15335
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15335
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15335
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70217/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15335
**[Test build #70217 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70217/testReport)**
for PR 15335 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15335
**[Test build #70217 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70217/testReport)**
for PR 15335 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/15335
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/15335
ok, I'll rerun tests to make sure and take a look.
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/15335
It's worth something, but not a lot. I think it's worth merging, but if
someone thinks it's not, I'm not going to fight it. Read it and merge if you
want to.
---
If your project is set up
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/15335
I'm just asking because you guys discussed this and seemed to reach an
agreement, but the PR is still open after a couple of months. I haven't
actually read the code, but can do if you think it
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/15335
@vanzin It should be committed if you think it adds enough additional
clarity that it is worth the penalty of making future backporting or other
debugging maintenance a little more difficult.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/15335
so is this still good? should it be committed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user squito commented on the issue:
https://github.com/apache/spark/pull/15335
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15335
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66272/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15335
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15335
**[Test build #66272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66272/consoleFull)**
for PR 15335 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15335
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66273/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15335
**[Test build #66273 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66273/consoleFull)**
for PR 15335 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15335
**[Test build #66273 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66273/consoleFull)**
for PR 15335 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15335
**[Test build #66272 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66272/consoleFull)**
for PR 15335 at commit
24 matches
Mail list logo
