Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #71007 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71007/testReport)**
for PR 15505 at commit
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/15505
@kayousterhout
Okay, I'll do the code revision this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15505
@witgo #16053 has been merged. Can you update the conflicts here, and then
we can merge this? Also, can you update the PR description to point to
SPARK-18890 now instead of SPARK-17931?
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70582/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #70582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70582/testReport)**
for PR 15505 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70516/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #70516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70516/testReport)**
for PR 15505 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #70516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70516/testReport)**
for PR 15505 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70501/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #70501 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70501/testReport)**
for PR 15505 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70507/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #70507 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70507/testReport)**
for PR 15505 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #70507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70507/testReport)**
for PR 15505 at commit
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/15505
@kayousterhout @squito
I think Kay's approach is a good idea.
We can first merging #16053, SPARK-18890 related code(including
multi-threaded serialization TaskDescription) to stay in the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #70501 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70501/testReport)**
for PR 15505 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15505
I fixed the #16053 issues unless there are more you're thinking of beyond
the ones I mentioned in the PR?
I was imagining merging this PR to fix SPARK-18890 (minus the changes that
Github user squito commented on the issue:
https://github.com/apache/spark/pull/15505
Looks like @kayousterhout posted some comments addressing my concerns on
https://github.com/apache/spark/pull/16053 at the same time as my last set of
comments. But essentially it sounds like Kay
Github user squito commented on the issue:
https://github.com/apache/spark/pull/15505
@witgo @kayousterhout where do we stand on this and
https://github.com/apache/spark/pull/16053? Both still viable alternatives?
https://github.com/apache/spark/pull/16053 is still missing
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70196/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #70196 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70196/consoleFull)**
for PR 15505 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #70196 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70196/consoleFull)**
for PR 15505 at commit
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/15505
@kayousterhout I agree with you, and do as you say.
@squito These a good idea, and worth a try. We can write a prototype to
verify it.
---
If your project is set up for it, you can reply to this
Github user squito commented on the issue:
https://github.com/apache/spark/pull/15505
I agree with Kay that putting in a smaller change first is better, assuming
it still has the performance gains. That doesn't preclude any further
optimizations that are bigger changes.
I'm
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15505
@witgo I don't mind moving the serialization out of resourceOffer, but I do
think it's helpful to separate that from the too-many-objects-serialized issue.
Smaller PRs are easier for folks
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/15505
@kayousterhout
Here are my thoughts:
move the serialization out of the `TaskSetManager.resourceOffer` method.
Split resourceOffer and serialization process, So that we can make the
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15505
@witgo I took a look at this and had an idea for an alternate approach that
is much simpler. Can you take a look at #16053 and let me know what you think?
If we decide to go with the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69129/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #69129 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69129/consoleFull)**
for PR 15505 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #69129 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69129/consoleFull)**
for PR 15505 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69077/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #69077 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69077/consoleFull)**
for PR 15505 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #69077 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69077/consoleFull)**
for PR 15505 at commit
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/15505
ping @kayousterhout / @squito / @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15505
This is pretty big and will miss 2.1.
But cc @kayousterhout / @squito / @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68141/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #68141 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68141/consoleFull)**
for PR 15505 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #68141 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68141/consoleFull)**
for PR 15505 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67179 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67179/consoleFull)**
for PR 15505 at commit
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/15505
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67159/consoleFull)**
for PR 15505 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67159/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67159 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67159/consoleFull)**
for PR 15505 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67126/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67126 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67126/consoleFull)**
for PR 15505 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67126 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67126/consoleFull)**
for PR 15505 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67110/consoleFull)**
for PR 15505 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67110/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67110/consoleFull)**
for PR 15505 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67109/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67109 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67109/consoleFull)**
for PR 15505 at commit
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/15505
@wzhfy
Ok, the code has been modified
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67109 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67109/consoleFull)**
for PR 15505 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/15505
There are many unnecessary changes, can you recover them to minimize diff?
That'll be easier for others to review. :)
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67056/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #67056 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67056/consoleFull)**
for PR 15505 at commit
68 matches
Mail list logo
