Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/15593
Thanks @dbtsai for your reply - yes that makes things clear. I didn't
realise we can use a Breeze matrix in the optimizers. That will definitely
help. I agree we should try to do that and simplify &
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/15593
Thanks @dbtsai!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/15593
Thanks all for working on this PR. I merged this into master, and I'll
create a followup task and PR to handle the abstraction together with handling
the smoothing in the initialization of
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/15593
Thanks for the detailed explanation @dbtsai. +1 for doing this in a
separate PR, since I'd imagine we want to run all the performance tests again
as well.
---
If your project is set up for it, you
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/15593
@MLnick I'm hoping that we could abstract out the the implementation of
using column major format as much as possible; as a result, in the future, new
developers can understand the code without
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/15593
@dbtsai I understand wanting to make things clear & easy to understand for
current and future developers. Of course I would like the same.
However, it's currently not clear to me how (or if)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15593
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15593
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68420/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15593
**[Test build #68420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68420/consoleFull)**
for PR 15593 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15593
**[Test build #68420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68420/consoleFull)**
for PR 15593 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15593
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15593
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68308/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15593
**[Test build #68308 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68308/consoleFull)**
for PR 15593 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15593
**[Test build #68308 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68308/consoleFull)**
for PR 15593 at commit
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/15593
@MLnick I updated it with your suggested wording for the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15593
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68084/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15593
**[Test build #68084 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68084/consoleFull)**
for PR 15593 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15593
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15593
**[Test build #68084 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68084/consoleFull)**
for PR 15593 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/15593
@sethah I'm recently busy on company work. Will start to work on open
source code review soon this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/15593
ping @MLnick @jkbradley This should be a nice performance boost for MLOR in
ML, hopefully we can get it in for 2.1. If you get some time to review or run
tests I'd really appreciate it.
---
If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15593
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67362/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15593
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15593
**[Test build #67362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67362/consoleFull)**
for PR 15593 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15593
**[Test build #67362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67362/consoleFull)**
for PR 15593 at commit
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/15593
cc @dbtsai
This may improve the problems you mentioned you were having on
[SPARK-17134](https://issues.apache.org/jira/browse/SPARK-17134) :)
---
If your project is set up for it, you can
26 matches
Mail list logo
