Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15608
merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15608
Yup, it seems not even `varargsToStrEnv`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15608
LGTM. I ran through a few other cases and I think the omitted names are
handled properly with this.
This should go to master then (handledCallJMethod is not in branch-2.0)
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67570/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15608
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15608
**[Test build #67570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67570/consoleFull)**
for PR 15608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15608
**[Test build #67570 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67570/consoleFull)**
for PR 15608 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15608
@felixcheung I just made it as a single for loop (slightly different with
the suggested one though..). Could you please check it again?
---
If your project is set up for it, you can reply to
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15608
I guess you meant when the options, for example,
`DataFrameReader.extraOptions` turns into `Properties` when we call JDBC APIs.
In this case, `Properties` always has a higher precedence and
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15608
re: JIRA - I don't mind one way or the other - both proposals sound good to
me.
> currently we don't make this failed when unused arbitrary options are
given (e.g. option("abc", "1")),
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15608
I am fine with leaving the JIRA open. I can definitely try to open
followups. Otherwise, I also can convert the JIRA as a sub-task after
introducing a parent JIRA.
I will follow your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15608
Thanks @HyukjinKwon This is definitely good checks to have. Calls to read.*
and write.* are not easily checked for parameters (file paths are hard) so to
me it is better to leave the checking
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67440/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15608
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15608
**[Test build #67440 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67440/consoleFull)**
for PR 15608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15608
**[Test build #67440 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67440/consoleFull)**
for PR 15608 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15608
cc @felixcheung I recall we talked about this before. I first wanted to
handle all the argument type checking but I just decided to do what I am pretty
sure of (I remember we were concern of
17 matches
Mail list logo
