Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15704
I am reverting this from 2.1. See
https://issues.apache.org/jira/browse/SPARK-18515 for more information.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
I feel that we are really so close to 2.1. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
I see. I agree. Thank you so much for cherry-picking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15704
@dongjoon-hyun I have cherry picked it into branch 2.1. Please note that I
will revert this as soon as it causes any problems, and then will push this to
2.2.
---
If your project is set up for
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Oh, @hvanhovell.
Can make a backport for branch-2.1 which will release this month?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you so much, @hvanhovell , @gatorsmile, @viirya !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15704
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Hi, @hvanhovell or @gatorsmile .
Could you merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68640/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68640 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68640/consoleFull)**
for PR 15704 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @hvanhovell !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15704
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68640 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68640/consoleFull)**
for PR 15704 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you for review, again. I'll fix them soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15704
LGTM and let's see if @hvanhovell has more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68559/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68559 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68559/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68559 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68559/consoleFull)**
for PR 15704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68550/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68550/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68550 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68550/consoleFull)**
for PR 15704 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @viirya . I added a prevention logic to prevent that case. Now
the PR works more like Hive.
Hi, @hvanhovell .
Could you review when you have sometime?
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68521/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68521 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68521/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68521 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68521/consoleFull)**
for PR 15704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68518/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68518 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68518/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68518 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68518/consoleFull)**
for PR 15704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68512 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68512/consoleFull)**
for PR 15704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68512/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68512 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68512/consoleFull)**
for PR 15704 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @viirya ! I also feel like that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15704
The changes to parsing looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @hvanhovell .
Now, this PR becomes much concise due to your advice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68503/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68503 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68503/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68503 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68503/consoleFull)**
for PR 15704 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @hvanhovell . I'll revise the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68055/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68055 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68055/consoleFull)**
for PR 15704 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15704
Making sense. I think we can collect all matched partitions for all given
specs. And do if exists check during the collecting. And then drop the distinct
partitions.
---
If your project is set up
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15704
When the partition specs have `equal to` only, our implementation first
checks all before starting the actual drop. See the
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15704
No. The first spec will drop the partition and the second spec will be
failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15704
Let us think this more carefully. In the following case, in which the
partition specs have the overlapping range
```Scala
sql("ALTER TABLE sales DROP PARTITION (quarter <= 3), PARTITION
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15704
Described in hive manual:
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-DropPartitions
In Hive 0.7.0 or later, DROP returns an error if the partition
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15704
Tonight, I did not finish the review, but I have a general question about
this PR:
```
ALTER TABLE table DROP [IF EXISTS] PARTITION spec1[, PARTITION spec2, ...]
```
It sounds
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68055 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68055/consoleFull)**
for PR 15704 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
I addressed all comments. For the upcoming comments, I'll handle them
tomorrow. Thank you so much always, @gatorsmile .
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68048/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68048 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68048/consoleFull)**
for PR 15704 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you, @gatorsmile ! I'll fix soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68048 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68048/consoleFull)**
for PR 15704 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you so much, @viirya . I added the testcase and fixed related bug
again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15704
LGTM except one comment for the test.
cc @hvanhovell for second look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68015/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68015 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68015/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #68015 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68015/consoleFull)**
for PR 15704 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15704
Thank you for review, @viirya . I'll fix them tomorrow~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67921/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #67921 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67921/consoleFull)**
for PR 15704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67919/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #67919 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67919/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #67921 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67921/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #67919 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67919/consoleFull)**
for PR 15704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67857/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #67857 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67857/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #67857 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67857/consoleFull)**
for PR 15704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67843/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15704
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #67843 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67843/consoleFull)**
for PR 15704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15704
**[Test build #67843 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67843/consoleFull)**
for PR 15704 at commit
84 matches
Mail list logo
