[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-09 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15816 If `result` is called before serialized, it has the same issue. Right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-09 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15816 @rdblue Can you send a new pr with the fix? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-09 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15816 Reverted from master/branch-2.1/branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-09 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15816 oh, seems the last commit did not pass build. Sorry. I am going to revert this patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-09 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15816 I am wondering if it breaks some tests? ``` org.apache.spark.sql.catalyst.expressions.MathExpressionsSuite.e org.apache.spark.sql.catalyst.expressions.MathExpressionsSuite.pi

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-09 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/15816 Thanks @rxin and @hvanhovell! I appreciate the quick reviews. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15816 I'm surprised too that we haven't caught this earlier ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15816 Merging in master/branch-2.1/branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15816 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68375/ Test PASSed. ---

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15816 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15816 **[Test build #68375 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68375/consoleFull)** for PR 15816 at commit

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15816 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15816 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68377/ Test FAILed. ---

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15816 **[Test build #68377 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68377/consoleFull)** for PR 15816 at commit

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15816 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68369/ Test PASSed. ---

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15816 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15816 **[Test build #68369 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68369/consoleFull)** for PR 15816 at commit

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/15816 @hvanhovell, I updated the test so that all expressions passed through `checkEvaluation` are serialized and deserialized before the checks are run. I'll open an issue if it catches anything else.

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15816 **[Test build #68377 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68377/consoleFull)** for PR 15816 at commit

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15816 **[Test build #68375 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68375/consoleFull)** for PR 15816 at commit

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15816 Sorry I missed your update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15816 Wow I am actually surprised that this wasn't caught before. Integration testing should have uncovered this. Could you add one? --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15816 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68373/ Test FAILed. ---

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15816 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15816 **[Test build #68373 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68373/consoleFull)** for PR 15816 at commit

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15816 **[Test build #68373 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68373/consoleFull)** for PR 15816 at commit

[GitHub] spark issue #15816: SPARK-18368: Fix regexp_replace with task serialization.

2016-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15816 **[Test build #68369 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68369/consoleFull)** for PR 15816 at commit