[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-12 Thread CodingCat
Github user CodingCat commented on the issue: https://github.com/apache/spark/pull/15853 Considering the current size of code base and the diversity of the required domain knowledge to ensure that the changes in all sub projects do not hurt, it is impossible to apply changes to the

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15853 It's not bad but there are a thousand things in the code that should be cleaned up. I think it could be OK if you sweep the code for similar patterns and fix all of some type. Just on principle and

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15853 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15853 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68545/ Test PASSed. ---

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15853 **[Test build #68545 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68545/consoleFull)** for PR 15853 at commit

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15853 **[Test build #68545 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68545/consoleFull)** for PR 15853 at commit

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-11 Thread CodingCat
Github user CodingCat commented on the issue: https://github.com/apache/spark/pull/15853 Eh...depends on how you define help...remove some unnecessary code is the only benefit...I am ok if you close it...just a 1 min work when reading the source code --- If your project is set up

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15853 It's OK by me but is it really helping? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15853 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68536/ Test PASSed. ---

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15853 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15853: [MINOR][SS] a minor refactor of getOffset in KafkaSource

2016-11-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15853 **[Test build #68536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68536/consoleFull)** for PR 15853 at commit