Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
New PR in #16221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
Hmm looking more closely I dont think the directory being deleted / being
in `dist/` is a real issue. This is because in `release-build.sh` we do `cd
..`[1] before trying to look for the file. I
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
I think release-tag.sh is only run while building RCs and final releases -
I dont think we run it for nightly builds - So thats not getting run as a part
of my test.
---
If your project is set
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
https://github.com/apache/spark/blob/202fcd21ce01393fa6dfaa1c2126e18e9b85ee96/dev/create-release/release-tag.sh
I mean.
---
If your project is set up for it, you can reply to
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
For the 2nd point, I thought make-tag.sh should update the version in
DESCRIPTION file. Was that not the case when we make preparations for 2.1.1?
---
If your project is set up for it,
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
No I found the problem - its two fold
- The tgz is not copied into the `dist` directory in `make-distribution.sh`
[1]. This is relatively easy to fix. It only works in Python because the entire
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
I'm guessing maybe the path needs to be a full path?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
This just means the source tgz file is not created?
Copying and signing R source package
cp: cannot stat
`spark-2.1.1-SNAPSHOT-bin-hadoop2.6/R/SparkR_2.1.1-SNAPSHOT.tar.gz': No such
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
Hmm - The problem is that the directory we want to get the file from gets
deleted in the previous step ? I'm going to debug this locally now.
---
If your project is set up for it, you can reply
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
Hmm still doesn't work
```
* DONE (SparkR)
+ popd
+ mkdir
/home/jenkins/workspace/spark-branch-2.1-package/spark-2.1.1-SNAPSHOT-bin-hadoop2.6/dist/conf
+ cp
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
@felixcheung I triggered a nightly build on branch-2.1 and this doesn't
work correctly in the no-hadoop build. While building the vignettes we run into
an error -- I'm going to change this to use
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
LGTM. I took another look at `release-build.sh` and I think it looks fine.
Merging this into master, branch-2.1. I'll also see if I can test this out
somehow on jenkins
---
If your project is
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
thanks, updated. @rxin could you please review release-build.sh?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69712/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16014
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16014
**[Test build #69712 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69712/consoleFull)**
for PR 16014 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16014
**[Test build #69712 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69712/consoleFull)**
for PR 16014 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16014
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69655/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16014
**[Test build #69655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69655/consoleFull)**
for PR 16014 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
Ah got it - I didn't notice that. BTW the way @rxin handled this for pip is
a bit different in
https://github.com/apache/spark/commit/37e52f8793bff306a7ae5a9aecc16f28333b70e3
Might be
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16014
**[Test build #69655 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69655/consoleFull)**
for PR 16014 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
As for release-build.sh - I had the change in there but I've changed it to
make it more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
@shivaram yes, that is correct and what I've found
[here](https://github.com/apache/spark/pull/16014#issuecomment-263505953)
Basically I don't think it is the R source package process
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
Sorry I was caught up with some other stuff today. Will take a final look
tomm morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
Any more thought on this? Without this we don't really have a signed
tarball in the official release to release to CRAN...
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16014
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69315/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16014
**[Test build #69315 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69315/consoleFull)**
for PR 16014 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16014
**[Test build #69315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69315/consoleFull)**
for PR 16014 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
@shivaram Cool, I did know about release-build but I didn't know it's
running on Jenkins. I *think* we should be ok but might want to check Jenkins
has "e1071" and "survival" which are optional
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16014
Why is this a blocker thing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16014
Just to clarify the Jenkins comment, we use Jenkins to test PRs and that
doesn't run make-distribution.sh -- But the main release builds (say 2.0.2[2])
are also built on Jenkins by a separate job
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
I thought we don't run `make-distribution.sh` on Jenkins, so I have been
testing it manually/locally.
As per
[here](https://github.com/apache/spark/pull/16014#discussion_r89912061) the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16014
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69175/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16014
**[Test build #69175 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69175/consoleFull)**
for PR 16014 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16014
@shivaram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16014
**[Test build #69175 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69175/consoleFull)**
for PR 16014 at commit
39 matches
Mail list logo
