Github user aray commented on the issue:
https://github.com/apache/spark/pull/16121
I'll take a look, sorry about that.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user stuarteberg commented on the issue:
https://github.com/apache/spark/pull/16121
This PR seems to have introduced a bug, which I have reported here:
https://issues.apache.org/jira/browse/SPARK-21985
Any thoughts, @aray? Can the check in question simply be
Github user davies commented on the issue:
https://github.com/apache/spark/pull/16121
LGTM, merging into master and 2.1 branch, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69865/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69865 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69865/consoleFull)**
for PR 16121 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69865 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69865/consoleFull)**
for PR 16121 at commit
Github user aray commented on the issue:
https://github.com/apache/spark/pull/16121
@davies, @zero323, and @holdenk this is in a good place for review if you
want to take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69674/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69674 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69674/consoleFull)**
for PR 16121 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69674 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69674/consoleFull)**
for PR 16121 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16121
I was hesistant with the previous PR since it seemed like we didn't fully
understand why we were changing what we were at the time, I can try and take a
closer look at this over the next few days
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69587/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69587/consoleFull)**
for PR 16121 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69587 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69587/consoleFull)**
for PR 16121 at commit
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16121
@davies I suggested workaround before but I remember that @holdenk had some
reservations.
Moreover it would have to be done proactively for all (?) calls. For
example
Github user aray commented on the issue:
https://github.com/apache/spark/pull/16121
@davies I was trying to make minimal changes to `PairDeserializer`, but you
are right it needs changed also. I'll update the PR shortly.
---
If your project is set up for it, you can reply to this
Github user davies commented on the issue:
https://github.com/apache/spark/pull/16121
It's pretty tricky to make the chained CartesianDeserializer work, maybe
it's easier to have a workaround in the RDD.cartesian() to add an
_reserialize() between chained cartesian (or zipped), it
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69573/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69573 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69573/consoleFull)**
for PR 16121 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69573 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69573/consoleFull)**
for PR 16121 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69571 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69571/consoleFull)**
for PR 16121 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16121
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69571/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16121
**[Test build #69571 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69571/consoleFull)**
for PR 16121 at commit
28 matches
Mail list logo