[GitHub] spark issue #16303: [SPARK-17807][core] Demote scalatest to "provided" in sp...

2016-12-19 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/16303 Closing in favor of the other PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16303: [SPARK-17807][core] Demote scalatest to "provided" in sp...

2016-12-16 Thread ryan-williams
Github user ryan-williams commented on the issue: https://github.com/apache/spark/pull/16303 I filed #16311 splitting out a spark-tags test-jar; turns out my second bullet above is a no-op since all Spark modules' test-jars are already automatically published, so that's neat.

[GitHub] spark issue #16303: [SPARK-17807][core] Demote scalatest to "provided" in sp...

2016-12-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16303 This may work in practice, but it doesn't sound like the right change. The scalatest dependency is correctly non-test because it is used by the tags that this module exposes from its non-test code.

[GitHub] spark issue #16303: [SPARK-17807][core] Demote scalatest to "provided" in sp...

2016-12-15 Thread ryan-williams
Github user ryan-williams commented on the issue: https://github.com/apache/spark/pull/16303 I appreciate the quick turn-around on this, though it seems like a mis-use of the `provided` scope. FWIW, I am advocating for: - `mv

[GitHub] spark issue #16303: [SPARK-17807][core] Demote scalatest to "provided" in sp...

2016-12-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16303 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70228/ Test PASSed. ---

[GitHub] spark issue #16303: [SPARK-17807][core] Demote scalatest to "provided" in sp...

2016-12-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16303 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16303: [SPARK-17807][core] Demote scalatest to "provided" in sp...

2016-12-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16303 **[Test build #70228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70228/testReport)** for PR 16303 at commit

[GitHub] spark issue #16303: [SPARK-17807][core] Demote scalatest to "provided" in sp...

2016-12-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16303 **[Test build #70228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70228/testReport)** for PR 16303 at commit