Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16323
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70564/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70564 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70564/testReport)**
for PR 16323 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70564 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70564/testReport)**
for PR 16323 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16323
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70561/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70561 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70561/testReport)**
for PR 16323 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16323
LGTM, pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70561/testReport)**
for PR 16323 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70547/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70547 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70547/testReport)**
for PR 16323 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70547 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70547/testReport)**
for PR 16323 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70505/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70505 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70505/testReport)**
for PR 16323 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16323
Updated. Please review @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70505 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70505/testReport)**
for PR 16323 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16323
SGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16323
Since adding a switch for cbo is not a trivial one, I want to do it in a
separate pr, and let this one only deal with decoupling Statistics from
CatalogTable. Do you agree? @cloud-fan
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70347/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70347 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70347/testReport)**
for PR 16323 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70347 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70347/testReport)**
for PR 16323 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16323
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70339/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70339 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70339/testReport)**
for PR 16323 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16323
Ok, I think it's doable. But since it's not a small change, let's wait
@rxin for his comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70330/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70330 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70330/testReport)**
for PR 16323 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16323
> we can't override it as lazy val, and def means we need to estimate the
plan every time statistics is called, which will be a performance hit.
I think we can do the cache manually:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70330 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70330/testReport)**
for PR 16323 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16323
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70328 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70328/testReport)**
for PR 16323 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70328/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70328 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70328/testReport)**
for PR 16323 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16323
Change LogicalPlan.statistics to def statistics(conf: CatalystConf) could
have two problems:
1. we can't override it as `lazy val`, and `def` means we need to estimate
the plan every time
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16323
cc @rxin @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70304/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70304 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70304/testReport)**
for PR 16323 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70304 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70304/testReport)**
for PR 16323 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70300/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70300 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70300/testReport)**
for PR 16323 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70300 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70300/testReport)**
for PR 16323 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70295/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16323
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70295 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70295/consoleFull)**
for PR 16323 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16323
**[Test build #70295 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70295/consoleFull)**
for PR 16323 at commit
55 matches
Mail list logo