Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16345
Thanks. Merging to master. This seems risky to backport to other branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16345
Ah, I see there's already other code that deals with retries and timeouts.
LGTM then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16345
> aren't you losing the timeout for the register RPC?
That's true. However, calling `System.exit(1)` for any timeout doesn't make
sense. In addition, since we will always retry to register
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16345
Hmm, I see... the worker needs to listen for RPC connections also, because
executors connect to it for "fate sharing"... so that means that when it
connects to the master, there are two TCP channels
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16345
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16345
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70390/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16345
**[Test build #70390 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70390/testReport)**
for PR 16345 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16345
**[Test build #70390 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70390/testReport)**
for PR 16345 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16345
cc @vanzin want to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
