[GitHub] spark issue #16469: [SPARK-19072][SQL] codegen of Literal should not output ...

2017-01-03 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/16469 LGTM. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16469: [SPARK-19072][SQL] codegen of Literal should not output ...

2017-01-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16469 some more explanation: when `Literal` codegen produce boxed values, the double equality will break, because the code is `(Double.isNaN(d1) && Double.isNaN(d2)) || d == d2` --- If your project

[GitHub] spark issue #16469: [SPARK-19072][SQL] codegen of Literal should not output ...

2017-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16469 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16469: [SPARK-19072][SQL] codegen of Literal should not output ...

2017-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16469 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70855/ Test PASSed. ---

[GitHub] spark issue #16469: [SPARK-19072][SQL] codegen of Literal should not output ...

2017-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16469 **[Test build #70855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70855/testReport)** for PR 16469 at commit

[GitHub] spark issue #16469: [SPARK-19072][SQL] codegen of Literal should not output ...

2017-01-03 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/16469 Thanks for the quick fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16469: [SPARK-19072][SQL] codegen of Literal should not output ...

2017-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16469 **[Test build #70855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70855/testReport)** for PR 16469 at commit

[GitHub] spark issue #16469: [SPARK-19072][SQL] codegen of Literal should not output ...

2017-01-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16469 cc @kayousterhout @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled