Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16495
Thanks @mhmoudr
As far as the stress test, I'd recommend posting instructions as a Github
gist and linking it to wherever you post results on JIRA or a PR. We wouldn't
want to add a model (a
Github user mhmoudr commented on the issue:
https://github.com/apache/spark/pull/16495
* To traing a (one-off) model a keep it in resources, then load it to run
the test.
* investigate the added comlexity issue.
* To move the test away from unit tests
* Provide
Github user mhmoudr commented on the issue:
https://github.com/apache/spark/pull/16495
Sure .. I am, but just a bit busy nowadays, in general I am planing to
investigate the additional complexity issue, and as for the test I agree with
the fact that the test should not be added to
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16495
@mhmoudr Will you be able to update this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vlad17 commented on the issue:
https://github.com/apache/spark/pull/16495
Yes, sorry for my wording. A unit test is indeed an inappropriate place for
stress tests. An offline test would be sufficient to verify that an O(N)
implementation is an improvement over the O(N^2)
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16495
The key point @vlad17 made was that an operation which should be O(N) is
taking O(N^2) in the current implementation. Let's fix that, regardless of
whether or not we add a stress test.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16495
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16495
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71003/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16495
**[Test build #71003 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71003/testReport)**
for PR 16495 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16495
**[Test build #71003 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71003/testReport)**
for PR 16495 at commit
10 matches
Mail list logo
