Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16660
Thanks! Merging to master/2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16660
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71980/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71980 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71980/testReport)**
for PR 16660 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71980 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71980/testReport)**
for PR 16660 at commit
Github user gmoehler commented on the issue:
https://github.com/apache/spark/pull/16660
Thanks for pointing out. I had overseen this comment.
Really appreciate you commitment to clean code!
Change is pushed and ready for a test build.
---
If your project is set up for it,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16660
@gmoehler `ExampleBaseClass` overrides `toString` impl. That is redundant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16660
LGTM except one comment. Thanks for working on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16660
The remaining comment is:
https://github.com/apache/spark/pull/16660#discussion_r97427591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gmoehler commented on the issue:
https://github.com/apache/spark/pull/16660
@viirya Which comment are you referring to? I thought i had included all of
them ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16660
LGTM except one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71929/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71929 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71929/testReport)**
for PR 16660 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71929/testReport)**
for PR 16660 at commit
Github user gmoehler commented on the issue:
https://github.com/apache/spark/pull/16660
Thanks for the valuable (and fast!) comments - i have worked them in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16660
It looks great! My comment is just to simplify the unit test cases.
Normally, we want to make the unit test cases as simple as possible. Thanks!
LGTM except a few minor comments.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71852/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71852 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71852/testReport)**
for PR 16660 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71852 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71852/testReport)**
for PR 16660 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71849 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71849/testReport)**
for PR 16660 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71849/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71849 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71849/testReport)**
for PR 16660 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71846/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71846 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71846/testReport)**
for PR 16660 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71846 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71846/testReport)**
for PR 16660 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71841 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71841/testReport)**
for PR 16660 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71841/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71841 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71841/testReport)**
for PR 16660 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71755/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71755 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71755/testReport)**
for PR 16660 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16660
**[Test build #71755 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71755/testReport)**
for PR 16660 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16660
You can add a test case in
https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala
---
If your project is set up for it, you can
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16660
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16660
LGTM too. @gmoehler Can you add a unit test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16660
is it possible to add a unit test? the change LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16660
cc @cloud-fan @rxin Although UDT is now private API, some developers still
use it by defining their codes as spark package. I am not sure if you think we
need to fix this or not.
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16660
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
44 matches
Mail list logo
