Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16738
@kayousterhout
Would you please give a look at this ? It's great if you could help review
this : )
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16738
@srowen
Thanks a lot. I'll refine : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16738
Rather than remove the comment, maybe it's better to clarify it as you say,
to refer to being "completed" rather than "successful". I don't know enough to
evaluate whether you're right about that
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16738
@srowen @jasonmoore2k
Thanks a lot for reviewing this PR~
>Should successful and tasksSuccessful renamed to be completed and
tasksCompleted?
How do you think about above
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16738
CC @jasonmoore2k for
https://github.com/apache/spark/pull/12751/files#diff-bad3987c83bd22d46416d3dd9d208e76L719
---
If your project is set up for it, you can reply to this email and have your
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16738
Should `successful` and `tasksSuccessful` renamed to be `completed` and
`tasksCompleted`?which I think make more sense.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16738
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
